Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix downstream test #1250

Merged
merged 3 commits into from
Aug 30, 2024

Conversation

contradict
Copy link
Contributor

NT.get_unit assumes DynamicQuantities, to use Unitful use MT.UnitfulUnitCheck.get_unit.

NT.get_unit assumes DynamicQuantities, to use Unitful use
MT.UnitfulUnitCheck.get_unit.
@contradict
Copy link
Contributor Author

@ChrisRackauckas I think this is a reasonable fix for this test.

@codecov-commenter
Copy link

codecov-commenter commented Aug 30, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.90%. Comparing base (47cfd60) to head (6cc8735).
Report is 49 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1250       +/-   ##
===========================================
+ Coverage    8.30%   37.90%   +29.59%     
===========================================
  Files          46       46               
  Lines        4549     4582       +33     
===========================================
+ Hits          378     1737     +1359     
+ Misses       4171     2845     -1326     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChrisRackauckas ChrisRackauckas merged commit 5a46ba5 into JuliaSymbolics:master Aug 30, 2024
8 of 11 checks passed
@ChrisRackauckas
Copy link
Member

@n0rbed when is the test fix coming?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants