Fix false positive result of passing a Function
to derivative
#1256
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #1085, e.g.
returns 0, when it should return the derivative of
sqrt
(which is not zero of course).Also added a catching method to throw for non-
Num
second input when first inputisa Function
.@ChrisRackauckas mentions in #1085 to add a catching method to report "
derivative
not supported fortypeof(f)
" which I couldn't understand, I'll need further explanation? I thought it made more sense to report lack of support forx isa Any
catch.He also mentions a check on if
x
is symbolic in any form, I'm also not sure what that means, i.e. what other forms thanNum
are supported?Complex{Num}
andInteger{Num}
? (Which errors on input tof
anyway.)Happy to make changes as desired.