Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added BasicSymbolic as input for function fed to derivative #1257

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kapple19
Copy link
Contributor

@kapple19 kapple19 commented Sep 4, 2024

And fixed TypeError usage.

Should hopefully be enough to close #1085.

@codecov-commenter
Copy link

codecov-commenter commented Sep 4, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.42%. Comparing base (47cfd60) to head (6bd882b).
Report is 64 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1257       +/-   ##
===========================================
+ Coverage    8.30%   80.42%   +72.11%     
===========================================
  Files          46       46               
  Lines        4549     4658      +109     
===========================================
+ Hits          378     3746     +3368     
+ Misses       4171      912     -3259     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChrisRackauckas
Copy link
Member

Can this get tests?

@kapple19
Copy link
Contributor Author

I should have time this weekend to look this through. I was confused as to how to write tests for this change.

@ChrisRackauckas
Copy link
Member

Bump?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Passing function to derivative results in zero
3 participants