fix: fix promote_symtype in register_array_symbolic with ndims
#1309
Conversation
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1309 +/- ##
==========================================
- Coverage 30.06% 3.80% -26.27%
==========================================
Files 47 47
Lines 4576 4602 +26
==========================================
- Hits 1376 175 -1201
- Misses 3200 4427 +1227 ☔ View full report in Codecov by Sentry. |
ext/SymbolicsGroebnerExt.jl
Outdated
| PrecompileTools.@setup_workload begin | ||
| @variables a b c x y z | ||
| simple_linear_equations = [x - y, y + 2z] | ||
| equations_intersect_sphere_line = [x^2 + y^2 + z^2 - 9, x - 2y + 3, y - z] | ||
| PrecompileTools.@compile_workload begin | ||
| symbolic_solve(simple_linear_equations, [x, y], warns=false) | ||
| symbolic_solve(equations_intersect_sphere_line, [x, y, z], warns=false) | ||
| end | ||
| end | ||
| # PrecompileTools.@setup_workload begin | ||
| # @variables a b c x y z | ||
| # simple_linear_equations = [x - y, y + 2z] | ||
| # equations_intersect_sphere_line = [x^2 + y^2 + z^2 - 9, x - 2y + 3, y - z] | ||
| # PrecompileTools.@compile_workload begin | ||
| # symbolic_solve(simple_linear_equations, [x, y], warns=false) | ||
| # symbolic_solve(equations_intersect_sphere_line, [x, y, z], warns=false) | ||
| # end | ||
| # end | ||
| # Disabled due to https://github.com/JuliaLang/julia/pull/55589 |
There was a problem hiding this comment.
this should just be removed then?
There was a problem hiding this comment.
It can be re-added once Julia gets the ability for extensions to depend on other extensions
There was a problem hiding this comment.
I should write a better doc for it. Will copy the one in #1310
There was a problem hiding this comment.
Sure, I'll remove it then
Depends on NemoExt, which won't be loaded due to JuliaLang/julia#55589
AayushSabharwal
force-pushed
the
as/arr-register-fix
branch
from
63e145f to
16ad8dc
Compare
No description provided.