Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make symbolic_evaluate unwrap everything it returns #1329

Merged

Conversation

AayushSabharwal
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Nov 4, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.03%. Comparing base (e036266) to head (34c1f5e).
Report is 51 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1329       +/-   ##
===========================================
+ Coverage    3.80%   78.03%   +74.23%     
===========================================
  Files          47       48        +1     
  Lines        4602     4771      +169     
===========================================
+ Hits          175     3723     +3548     
+ Misses       4427     1048     -3379     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChrisRackauckas
Copy link
Member

Why is this necessary? Test?

@AayushSabharwal
Copy link
Contributor Author

This was motivated by SciML/SciMLBase.jl#837 (comment). Interestingly, the relevant MTK test passed when the PR was merged. I'm unsure why.

@ChrisRackauckas ChrisRackauckas merged commit 8530457 into JuliaSymbolics:master Nov 4, 2024
12 of 24 checks passed
@AayushSabharwal AayushSabharwal deleted the as/symeval-unwrap branch November 4, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants