Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix searching inside callable symbolics in get_variables! #1361

Conversation

AayushSabharwal
Copy link
Contributor

@AayushSabharwal AayushSabharwal commented Nov 15, 2024

Close #1351

@codecov-commenter
Copy link

codecov-commenter commented Nov 15, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 78.99%. Comparing base (5af597a) to head (0514859).
Report is 18 commits behind head on master.

Files with missing lines Patch % Lines
ext/SymbolicsLuxExt.jl 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1361       +/-   ##
===========================================
+ Coverage    3.98%   78.99%   +75.01%     
===========================================
  Files          50       51        +1     
  Lines        4771     4880      +109     
===========================================
+ Hits          190     3855     +3665     
+ Misses       4581     1025     -3556     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AayushSabharwal
Copy link
Contributor Author

Lux seems to have broken this extension pretty badly. The outputsize internals changed in LuxDL/Lux.jl#1069 which is causing all of this.

@SebastianM-C
Copy link
Contributor

Yeah, we might have to overload other things, to get the output size correctly.

@ChrisRackauckas ChrisRackauckas merged commit 3485fbb into JuliaSymbolics:master Nov 15, 2024
10 of 12 checks passed
@AayushSabharwal AayushSabharwal deleted the as/get-variables-callable branch November 16, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

get_variables doesn't work for function arguments
4 participants