Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support symbolic_solve([equations]) #1367

Merged
merged 3 commits into from
Nov 18, 2024

Conversation

n0rbed
Copy link
Member

@n0rbed n0rbed commented Nov 18, 2024

symbolic_solve([x+y ~ 1, x-y~0])

This used to error because the function which handles symbolic_solve(eq) was not converting the input to Nums before detecting the input vars.

Copy link
Member

@ChrisRackauckas ChrisRackauckas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a test

@codecov-commenter
Copy link

codecov-commenter commented Nov 18, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.03%. Comparing base (2784b7e) to head (58ff391).
Report is 1 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1367       +/-   ##
===========================================
+ Coverage    3.98%   79.03%   +75.04%     
===========================================
  Files          51       51               
  Lines        4793     4888       +95     
===========================================
+ Hits          191     3863     +3672     
+ Misses       4602     1025     -3577     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChrisRackauckas ChrisRackauckas merged commit 2bc3c54 into JuliaSymbolics:master Nov 18, 2024
10 of 12 checks passed
@n0rbed n0rbed deleted the quick_fix branch November 18, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants