Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove IfElse.jl #1449

Merged
merged 1 commit into from
Feb 25, 2025
Merged

Conversation

devmotion
Copy link
Contributor

This PR removes remaining traces of IfElse.jl.

Fixes #900.

@codecov-commenter
Copy link

codecov-commenter commented Feb 25, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 8.83%. Comparing base (eced900) to head (a2ba1fc).
Report is 30 commits behind head on master.

Files with missing lines Patch % Lines
src/extra_functions.jl 0.00% 5 Missing ⚠️
src/diff.jl 0.00% 1 Missing ⚠️
src/num.jl 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##           master   #1449      +/-   ##
=========================================
- Coverage    8.88%   8.83%   -0.05%     
=========================================
  Files          51      51              
  Lines        4876    4903      +27     
=========================================
  Hits          433     433              
- Misses       4443    4470      +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChrisRackauckas ChrisRackauckas merged commit 4d3cfd9 into JuliaSymbolics:master Feb 25, 2025
9 of 13 checks passed
@ChrisRackauckas
Copy link
Member

Wow, I completely forgot we had any IfElse.jl left 😅

@devmotion
Copy link
Contributor Author

I just noticed that SymbolicUtils also still depends on it: JuliaSymbolics/SymbolicUtils.jl#706 😄

@devmotion devmotion deleted the dw/ifelse branch February 25, 2025 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: mention after 1.8 IfElse.ifelse is Base.ifelse
3 participants