Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specialize in(x::Union{Sym,Term,Num}, I::TypedEndpointsInterval) #797

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

jishnub
Copy link

@jishnub jishnub commented Nov 30, 2022

Along with JuliaMath/IntervalSets.jl#126, this helps avoid ambiguities such as in JuliaApproximation/ApproxFun.jl#847

Let's wait for a decision on JuliaMath/IntervalSets.jl#126 before this

Edit: I've updated this to define in for TypedEndpointsInterval. Adding IntervalSets as a dependency does not impact load times, as it's loaded by DomainSets anyway. While TypedEndpointsInterval is not exported by IntervalSets, it's quite a fundamental type as, among other things, Interval and ChebyshevInterval are subtypes of this.

With this PR, the following works:

julia> using Symbolics

julia> @variables x
1-element Vector{Num}:
 x

julia> using DomainSets

julia> x in ChebyshevInterval()
Symbolics.VarDomainPairing(x, -1.0..1.0 (Chebyshev))

@jishnub jishnub changed the title Specialize in(x::Num, I::AbstractInterval) Specialize in(x::Union{Sym,Term,Num}, I::AbstractInterval) Nov 30, 2022
@jishnub jishnub marked this pull request as draft November 30, 2022 14:47
@jishnub jishnub changed the title Specialize in(x::Union{Sym,Term,Num}, I::AbstractInterval) Specialize in(x::Union{Sym,Term,Num}, I::TypedEndpointsInterval) Dec 1, 2022
@jishnub jishnub marked this pull request as ready for review December 1, 2022 10:02
Project.toml Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Mar 17, 2023

Codecov Report

Merging #797 (2ee927e) into master (3bad882) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master     #797      +/-   ##
==========================================
- Coverage   76.83%   76.81%   -0.03%     
==========================================
  Files          26       26              
  Lines        3238     3239       +1     
==========================================
  Hits         2488     2488              
- Misses        750      751       +1     
Impacted Files Coverage Δ
src/domains.jl 40.00% <0.00%> (-4.45%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@benjione
Copy link

Is there some progress on that?
I would benefit from this being merged, enabling me to use SumOfSquares.jl together with ApproxFun.jl.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants