Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement methods for LogExpFunctions #993

Merged
merged 2 commits into from
Oct 10, 2023

Conversation

theogf
Copy link
Contributor

@theogf theogf commented Oct 9, 2023

Fixes #931

This adds LogExpFunctions as an explicit dependency (already was an implicit one).

For each function where it would error on Num values, a new specialized method was added.

@ChrisRackauckas
Copy link
Member

@ChrisRackauckas ChrisRackauckas merged commit 327a030 into JuliaSymbolics:master Oct 10, 2023
13 of 17 checks passed
@theogf theogf deleted the logexpfunctions branch October 10, 2023 09:32
@ArnoStrouwen
Copy link
Contributor

@ArnoStrouwen did you look into https://github.com/JuliaSymbolics/Symbolics.jl/actions/runs/6458255398/job/17531947753?pr=993#step:5:10 before?

Yes, mathengine is passed wrongly to makedocs instead of Documenter.HTML.
Bracket closed to early.
Fix should be included here:
#978

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implementing logsumexp and related functions from LogExpFunctions.jl for Num
3 participants