Summary of changes in this commit: #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Factor ERR_clear_error into its own function and call in the geterror macro right before we do SSL IO operations;
the openssl docs recommend this and trying to keep your error stack as clean as possible
* Add :acquire/:release memory orderings to our atomic operations; shouldn't make that big of a difference, but
more semantically correct with how we define our atomicget/atomicset macros
* Instead of call `eof(ssl)` before each SSL_read_ex call, we instead only check that the ssl is open, then
optimistically call SSL_read_ex; if there are buffered bytes, they'll be processed and we saved ourselves
an `eof` call; if SSL_read_ex returns SSL_WANT_READ, then we'll call `eof` anyway afterwards
* Remove the finalizer on our SSL struct; @kpamnany recommended avoiding finalizers and we already have really
well defined create/destroy moments for SSLs, so we don't need to be messing w/ the global finalizer list
* Remove 2 `update_tls_error_state` calls in SSL_pending and SSL_has_pending; these aren't needed because
the openssl documentation mentions specifically these don't use the same error reporting as IO functions
* Also tweaked our eof call to avoid allocating a Ref{UInt8} each time it is called
Codecov Report
@@ Coverage Diff @@
## main #18 +/- ##
==========================================
- Coverage 75.78% 75.70% -0.09%
==========================================
Files 2 2
Lines 1049 1062 +13
==========================================
+ Hits 795 804 +9
- Misses 254 258 +4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Co-authored-by: Nick Robinson <[email protected]>
Co-authored-by: Nick Robinson <[email protected]>
Co-authored-by: Nick Robinson <[email protected]>
|
Thanks for the great review + suggestions @nickrobinson251; GitHub was being super weird and the UI wasn't working very well, so I managed to commit a few of your changes and made the others locally and pushed. Should be all addressed now! |
nickrobinson251
approved these changes
Apr 11, 2023
|
Yeah, that's a good point. And honestly, the easiest part is probably just removing most of the code in the OpenSSL.jl file, since we don't really use it/depend on it for the SSLStream stuff. I've opened this issue to follow up on that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eof(ssl)before each SSL_read_ex call, we instead only check that the ssl is open, then optimistically call SSL_read_ex; if there are buffered bytes, they'll be processed and we saved ourselves aneofcall; if SSL_read_ex returns SSL_WANT_READ, then we'll calleofanyway afterwardsupdate_tls_error_statecalls in SSL_pending and SSL_has_pending; these aren't needed because the openssl documentation mentions specifically these don't use the same error reporting as IO functions