Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first attempt at loading a dedicated logger with WebSockets, and the added functionality would bump version number to 1.3.0 (1.2.0 added a number of 'show' methods').
The current logging implementation in Julia standard libraries can be used quite creatively (ref. Revise, Rebugger), and can possibly be fast as well. For applications with websockets, logging is especially helpful in determining the actual timing and bottlenecks between multiple threads of execution.
Logging utilities in this package has already seen some iterations and is mentioned in 23 issues. This PR refers issue #111. From inline doc:
modified: README.md WebSocketLogger and v1.3.0
new file: examples/count_with_logger.jl Logging async Websocket peers
modified: examples/minimal_server.jl Use WebSocketLogger
deleted: logutils/log_http.jl
deleted: logutils/logutils_ws.jl
new file: src/Logger/websocketlogger.jl stdlib/ConsoleLogger + /logutils.jl
modified: src/WebSockets.jl Include / export WebSocketLogger, @WSLog
modified: test/logformat.jl ConsoleLogger -> WebSocketLogger
modified: test/runtests.jl Include test_websoketlogger.jl
new file: test/test_websocketlogger.jl