Parameter history #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note:
have to fix setting case if "undo Fit" was initiatet do not append paramters to paraenter history list
Indeed, I will tackle this topic in September/October! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My previous comment #13 about creating a parameter class for the "undo fit" functionality is not as practical as I thought at the beginning. The parameters are already inizialized in the lmfit.Parameters.parameter classe and you also need the presets for the GUI.
So here I added a history_manager() and one_step_back_in_params_history() methods which create a list self.parameter_history_list and handle the history of the fits.
Notice:
At the moment after pressing "undo Fit" button the parameters/presets are set to the previous value and it is fit again, because the evaluation method doesn't work for me, better said I didn't test it enough.