4 frontend statscard component #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wkim10
reviewed
Oct 27, 2024
src/components/StatsCard.tsx
Outdated
|
|
||
| const StatsCard = ({ heading, value, icon, date }: StatsCardProps) => { | ||
| return ( | ||
| <div className="w-[360px] h-[160px] h-40 px-6 py-4 bg-white rounded-lg shadow border border-[#e4e7ec] flex-col justify-start items-start gap-4 inline-flex"> |
There was a problem hiding this comment.
nit: h-[160px] and h-40 do the same thing so you can remove one
wkim10
approved these changes
Oct 27, 2024
wkim10
reviewed
Oct 27, 2024
src/app/page.tsx
Outdated
|
|
||
| export default function Home() { | ||
| return ( | ||
| <div className="flex items-center justify-center h-screen"> | ||
| {/* Example Button (ExampleButton.tsx in components folder) */} | ||
| <ExampleButton buttonText="Add User" /> | ||
| <StatsCard |
There was a problem hiding this comment.
Also I forgot but can you remove the components from this file before you merge?
Co-authored-by: Conrad Hsu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Created the statscard which has 4 variables, a title, a number value, a date and an icon.
Issues
#4
Screenshots
The user won't be doing any tasks with the card besides reading it
Test
Compare to figma using npm run dev
Possible Downsides
The sizing may not be perfect compared to the figma but we tried to make it as close as possible. It is a bit difficult to tell when the fonts are not the same yet.
Additional Documentations
For icons: https://iconify.design/