Frontend log in flow #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…read-and-roses into frontend-log-in-flow
Closed
wkim10
reviewed
Nov 12, 2024
wkim10
reviewed
Nov 12, 2024
src/components/Login.tsx
Outdated
| }; | ||
|
|
||
| return ( | ||
| <div className="flex flex-col items-center" style={{ minHeight: "100vh" }}> |
There was a problem hiding this comment.
Could you guys use Tailwind styling when possible? I know it might not work with MUI components but for regular tags like divs let's keep it consistent!
wkim10
reviewed
Nov 12, 2024
wkim10
reviewed
Nov 12, 2024
wkim10
approved these changes
Nov 12, 2024
There was a problem hiding this comment.
Looks really great guys, good work! In general, one thing to look out for is small things that ESLint gets mad about, you can check to see if there's anything it doesn't like by running npm run build before you make a PR.
Made a few small comments but after you address them feel free to merge!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add login and some error handling