Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Welcome Page #57

Merged
merged 4 commits into from
Dec 8, 2024
Merged

Welcome Page #57

merged 4 commits into from
Dec 8, 2024

Conversation

claireslee
Copy link
Collaborator

We created the new home page and added the necessary front end details! We also worked on the language button.

41 - #41

Does your code meet the acceptance criteria?

  • Yes # put an x in the brackets to checkmark!

Testing done and screenshots (if relevant)

Other comments

Copy link
Collaborator

@myix765 myix765 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi guys, thanks for working on the Welcome page! I think there was a little confusion about what the ticket is asking for (which is my fault cause I edited the ticket after releasing it) but the goal of the ticket wasn't to create the i18nextLng token in localStorage, that was just an example. What we want for the Welcome page is to display it if the user is a first time visitor to the site, and to do that we want to create a new token in localStorage so that if the token doesn't exist, we know they're a new user and we create the token and them the Welcome page. Then the next time the user visits the page, the token will now exist so we show them the Home page.

Sorry if that was unclear in the ticket, let me know if you still have any questions!

@Sanderson28801
Copy link
Collaborator

I updated the branch and added the localstorage variable you asked for. Should work now, sorry this took so long

@myix765
Copy link
Collaborator

myix765 commented Dec 8, 2024

Nice job guys! I made some edits so that the Welcome page always shows up when the user first visits the site, if you're interested in how I did that feel free to look at the changes I made!

@myix765 myix765 merged commit eb994d1 into main Dec 8, 2024
1 check passed
@myix765 myix765 deleted the Welcome_Page branch December 8, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants