Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change RtPolicy RT elements from ObjectId to string #145

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

chrismarget-j
Copy link
Collaborator

@chrismarget-j chrismarget-j commented Oct 19, 2023

ImportRTs and ExportRTs are strings of the form "123:456".

They should not have been ObjectId type. They don't seem to be used anywhere except in a test related to Virtual Networks, which still passes against versions 4.1.0, 4.1.1, 4.1.2 and 4.2.0.

Closes #144

Copy link
Collaborator

@bwJuniper bwJuniper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@chrismarget-j chrismarget-j merged commit ca57403 into main Oct 20, 2023
1 check passed
@chrismarget-j chrismarget-j deleted the bug/144-rt-objectid-vs-string branch October 20, 2023 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Import/Export RT type should be string not ObjectId
3 participants