Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add JSON marshal/unmarshal to generated enum code #481

Merged
merged 3 commits into from
Jan 7, 2025
Merged

Add JSON marshal/unmarshal to generated enum code #481

merged 3 commits into from
Jan 7, 2025

Conversation

chrismarget-j
Copy link
Collaborator

@chrismarget-j chrismarget-j commented Jan 6, 2025 •
edited
Loading

This PR modifies the apstra/enum/generator/generator.go program which produces apstra/enum/generated_enums.go.

The generated enum code now ensures that these types fulfill the json.Marshaler and json.Unmarshaler interfaces.

@chrismarget-j chrismarget-j mentioned this pull request Jan 7, 2025
Merged
@chrismarget-j chrismarget-j merged commit 3cbb504 into main Jan 7, 2025
2 checks passed
@chrismarget-j chrismarget-j deleted the enum-unmarshal-json branch January 7, 2025 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rajagopalans rajagopalans rajagopalans approved these changes

@bwJuniper bwJuniper Awaiting requested review from bwJuniper

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chrismarget-j @rajagopalans