This loop was written as if the 'test' structure is a copy of the #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
self.test_details list, but it is only a reference to it, setting test['command'], and del test['test_name'] alters self.test_details. Referring to testname_results twice will crash as self.test_details['test_name'] has been deleted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
self.test_details list, but it is only a reference to it, setting
test['command'], and del test['test_name'] alters self.test_details.
Referring to testname_results twice will crash as
self.test_details['test_name'] has been deleted.
What does this PR do?
What issues does this PR fix or reference? PR 330
Previous Behavior
looping over testname_results would crash the app
New Behavior
Leaves test_details['test_name'] in the dict so it does not crash
Tests written?
Test written in PR330 comments, need to know how to put that into code test