Add support for Environment variables JSNAPY_PASSWORD and JSNAPY_USERNAME #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds functions, tests, and documentation for class methods
SnapAdmin.get_device_login()
SnapAdmin.get_device_passwd()
What issues does this PR fix or reference?
NO PR / I had a use case for SnapAdmin pulling username and password from environment variables.
Previous Behavior
Pulled password from command line or the inventory
New Behavior
Still pulls from command line or inventory, but with an added check of the environment variables
JSNAPY_USERandJSNAPY_PASSWORDTests written?
Yes