New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change validation `ExactlyOneOf` -> `AtMostNOf` #377

Merged

chrismarget-j merged 1 commit into main from bug/376-eliminate-mandatory-filter

Sep 29, 2023

Collaborator

chrismarget-j commented Sep 28, 2023

The recent change to allow use of filters rather than filter in data source apstra_datacenter_systems did so by:

deprecating filter via warning message
introducing filters
validating that exactly one of filter and filters was configured.

"exactly one" is the problem. It should be possible to get un-filtered results.

This PR changes the "exactly one" filter to "at most N" where N = 1.

Closes #376


          change validation ExactlyOneOf -> AtMostNOf

b362de2

chrismarget-j requested review from bwJuniper and rajagopalans

September 28, 2023 23:09

bwJuniper approved these changes

View reviewed changes

chrismarget-j merged commit df7a375 into main

chrismarget-j deleted the bug/376-eliminate-mandatory-filter branch

October 2, 2023 12:47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet