Fix nil pointer deref when GetNodeRenderedConfigDiff() returns 404
#968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajagopalans
approved these changes
Nov 6, 2024
chrismarget-j
deleted the
967-nil-pointer-derek-when-incremental-config-not-available
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calls to
GetNodeRenderedConfigDiff()may return error due to 404 from the API.#964 introduced a change which made these errors not fatal for the data source. We want to just return a
nullincremental config in those cases.Unfortunately, the incremental config is returned via a
*apstra.RenderDiff(a pointer), which isnilon 404. Because 964 causes us to not return, we go on to dereference a value within that nil struct pointer, leading to a crash.This PR tightens up the preceding code a bit (disambiguates some stuff no longer needed since #964) and checks the pointer before attempting to dereference the config diff.
Closes #967