Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always add folderTitle to dashboard object to avoid broken UI card #73

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Shandur
Copy link

@Shandur Shandur commented Jul 20, 2023

If you use folderTitle dashboard selector in annotations, it might break the Dashboards card component with an error identifier folderTitle does not exist.
The error happens if there is at least one dashboard in the response without a folderTitle field.

Example of annotation:

metadata:
  annotations:
    grafana/dashboard-selector: folderTitle == 'Cool Folder Title'

Tested it with my project - works nicely!

@Shandur
Copy link
Author

Shandur commented Jul 20, 2023

@K-Phoen Would appreciate feedback (and merge) from you 🙌

@roman-shandurenko
Copy link

@K-Phoen up 👋

@roman-shandurenko
Copy link

@kcrabbe up :)

@martina-equinix
Copy link

Hey @Shandur, this plugin has moved to the community plugins repo. Can you open the PR there instead?
https://github.com/backstage/community-plugins/tree/main/workspaces/grafana

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants