cxx-qt-lib: Add bindings for QMessageLogContext and qt_message_output #814
+256
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redstrate
commented
Jan 17, 2024
|
Hi, |
redstrate
force-pushed
the
wip/josh/qtlogging
branch
from
5b47aee to
c8364f2
Compare
redstrate
force-pushed
the
wip/josh/qtlogging
branch
from
c8364f2 to
f9950b7
Compare
LeonMatthesKDAB
requested changes
Feb 14, 2024
redstrate
force-pushed
the
wip/josh/qtlogging
branch
6 times, most recently
from
40efe50 to
7dc5dbb
Compare
redstrate
force-pushed
the
wip/josh/qtlogging
branch
2 times, most recently
from
f519be1 to
78b72af
Compare
redstrate
force-pushed
the
wip/josh/qtlogging
branch
3 times, most recently
from
bff8d3a to
88eaa9e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #814 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 71 71
Lines 11967 11967
=========================================
Hits 11967 11967 ☔ View full report in Codecov by Sentry. |
redstrate
force-pushed
the
wip/josh/qtlogging
branch
4 times, most recently
from
d204d89 to
9e0cd75
Compare
LeonMatthesKDAB
requested changes
Jan 10, 2025
redstrate
force-pushed
the
wip/josh/qtlogging
branch
2 times, most recently
from
61dc340 to
6b03a11
Compare
There was a problem hiding this comment.
I'm pretty happy with this PR now.
Having static_assertions would be a plus. Waiting for opinion from @ahayzen-kdab there.
redstrate
force-pushed
the
wip/josh/qtlogging
branch
from
6b03a11 to
1e8003a
Compare
redstrate
commented
Jan 15, 2025
redstrate
force-pushed
the
wip/josh/qtlogging
branch
from
1e8003a to
438b6c4
Compare
This allows Rust and CXX-Qt applications to send messages to the Qt logger.
redstrate
force-pushed
the
wip/josh/qtlogging
branch
from
438b6c4 to
7326ea0
Compare
redstrate
changed the title
This is needed to ensure the Rust-side QMessageLogContext struct has the expected size.
redstrate
force-pushed
the
wip/josh/qtlogging
branch
from
7326ea0 to
68454a7
Compare
LeonMatthesKDAB
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows Rust and CXX-Qt applications to send messages to the Qt logger.