-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KDT0_KimMinSeob 사진관리서비스 #63
Open
LikeFireAndSky
wants to merge
34
commits into
main
Choose a base branch
from
KDT0_KimMinSeob
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
44620c1
Feat : Add Modal window
LikeFireAndSky 7206e8e
Feat Api
LikeFireAndSky eab226d
good
LikeFireAndSky 8ef14b9
Feat
LikeFireAndSky ce06a02
df
LikeFireAndSky 78a008c
change public folder
LikeFireAndSky 09cbc0d
DEP1
LikeFireAndSky 3dce8f7
Fix api key
LikeFireAndSky 7eeb8f0
Fix import issue
LikeFireAndSky 389c686
vercel add
LikeFireAndSky 1fc9ce8
Test Api firebaseStore
LikeFireAndSky bdca643
Deploy Version
LikeFireAndSky 2561851
Dep : Deploy Version
LikeFireAndSky c80d906
Fix : Dep Version
LikeFireAndSky e1becc2
FIX : DELETE FILES
LikeFireAndSky c6c06c8
Fix : REadMe
LikeFireAndSky 51cfda6
FEAT : Add Confetii effect
LikeFireAndSky 74d4a15
Fix : webpack.config.js, firebase-id ID가 한글일 때 오류
LikeFireAndSky 5cffbdd
Fix : Modal Mobile UI's overflow problem
LikeFireAndSky c0328ed
Refact : Add NotFound Page
LikeFireAndSky 9aad370
Fix : Add Update-Modal Delete Button
LikeFireAndSky 3dea142
Design : place modal-delete button on the modal
LikeFireAndSky c912996
FIX : Package.json 파일 수정, DEPENDENCY.md 파일 추가
LikeFireAndSky c6c5f7c
Fix : 이미 tagName default 값이 div이기 때문에 div를 없애줌
LikeFireAndSky 466c793
FiX : addUpdate.js else로 예외처리 추가
LikeFireAndSky add6323
Fix : Confetti.js 변수 이름들 변경 및 코드 정리
LikeFireAndSky 2459bd2
Fix : FirstPage.js tagName -> li, li요소들 반복문으로 생성
LikeFireAndSky 127ac09
Fix : Delete all console.log
LikeFireAndSky 8d7b251
Fix : 변수 명 변경, el, btn등 축약어 사용하지 않음
LikeFireAndSky d39f1cd
Fix : core/index.js파일 분리, router.js, store.js 추가
LikeFireAndSky bf13ca2
Fix : add DotEnv and Hide Firebase Config
LikeFireAndSky 3891647
Fix : render()에 몰려있는 기능을 다른 메소드들로 분리
LikeFireAndSky 0aa67cc
Fix : AddMyValley.js eventListener 분리
LikeFireAndSky 34af55f
FIX : Button에 Type추가
LikeFireAndSky File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
발생 오류
ID값이 한글일 때 about 페이지에서 보이지 않는 문제가 발생
변경 내용
ID 값을 nickname이 아닌 고정 sting 값으로 변경
해결 과정
ID 값이 한글 일 때 list페이지에서는 보여지지만 about페이지에서 보여지지 않는 이유를 생각해봤을 때 about 페이지에서 데이터를 보기 위해서 ID를 query를 통해서 쐈기 때문에 한글이 query로 들어가서 문제가 발생하는 것이라고 생각해서 ID에 한글이 들어가지 않게 독립적인 ID로 변경하였음
리뷰관련
ID값이 현재 유닉스 데이트타임이기 때문에 보안상으로 취약할 수 있다는 문제가 야기 될 것 같다고 생각합니다. 따라서 ID값을 자동으로 지정해주는 기능을 쓰거나 암호화를 통해서 해당 문제를 해결해 볼 수 있을 것 같습니다.