Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

k-32: Abstracted pfs_client method in job_service #104

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

k-32: Abstracted pfs_client method in job_service #104

wants to merge 2 commits into from

Conversation

ms-shankar
Copy link
Contributor

Description

Closes #32

Checklist

  • An issue was first created before opening this pull request
  • The new code follows the kaos contribution guidelines
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests to ensure that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@ms-shankar ms-shankar requested review from ImScientist and jfri3d and removed request for ImScientist January 24, 2020 14:49
@ms-shankar ms-shankar self-assigned this Jan 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aalhour aalhour Awaiting requested review from aalhour

@ImScientist ImScientist Awaiting requested review from ImScientist

@jfri3d jfri3d Awaiting requested review from jfri3d

At least 1 approving review is required to merge this pull request.

Assignees

@ms-shankar ms-shankar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix broken encapsulation
1 participant
@ms-shankar