Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

k-91: Remote backend init for remote clusters #89

Merged
merged 8 commits into from
Dec 18, 2019
Merged

k-91: Remote backend init for remote clusters #89

merged 8 commits into from
Dec 18, 2019

Conversation

ms-shankar
Copy link
Contributor

@ms-shankar ms-shankar commented Nov 26, 2019 •
edited
Loading

Description

Closes bug/issue #91. Initialisation of remote kaos cluster validation check added

Checklist

  • An issue was first created before opening this pull request
  • The new code follows the kaos contribution guidelines
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests to ensure that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@atselikov atselikov closed this Nov 26, 2019
atselikov
atselikov reviewed Nov 26, 2019
View reviewed changes
Copy link
Contributor

@atselikov atselikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@ms-shankar ms-shankar reopened this Nov 26, 2019
atselikov
atselikov reviewed Nov 26, 2019
View reviewed changes
Copy link
Contributor

@atselikov atselikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@ms-shankar ms-shankar self-assigned this Nov 26, 2019
@ms-shankar ms-shankar changed the title k-xxx fixed is_created during remote init k-91: Remote backend init fixed after k-14 changes Nov 26, 2019
@ms-shankar ms-shankar added the bug Something isn't working label Nov 26, 2019
@ms-shankar ms-shankar requested a review from aalhour November 26, 2019 15:42
@ms-shankar ms-shankar changed the title k-91: Remote backend init fixed after k-14 changes k-91: Remote backend init for remote clusters Nov 26, 2019
@ImScientist ImScientist mentioned this pull request Dec 16, 2019
Open
aalhour
aalhour approved these changes Dec 18, 2019
View reviewed changes
Copy link
Contributor

@aalhour aalhour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aalhour aalhour merged commit eaa34b7 into master Dec 18, 2019
@aalhour aalhour deleted the k-xxx-fixed-init-is_created-bug-for-remote-backend branch December 18, 2019 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atselikov atselikov atselikov left review comments

@aalhour aalhour aalhour approved these changes

@jfri3d jfri3d Awaiting requested review from jfri3d

Assignees

@ms-shankar ms-shankar

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ms-shankar @aalhour @atselikov