Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only allow one release workflow at a time #101

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

ll-nick
Copy link
Collaborator

@ll-nick ll-nick commented Dec 9, 2024

This makes sure that only one release workflow runs at a time, even if multiple PRs have been merged in close concession.
Running workflows won't be canceled; newer workflows will wait in line to run after the current one finishes.

See here for a full documentation of the utilized settings.

This closes #97 .

#patch

Do not cancel running workflows but queue them to run at a later time.
@ll-nick ll-nick requested a review from orzechow December 9, 2024 09:21
@ll-nick ll-nick self-assigned this Dec 9, 2024
@ll-nick
Copy link
Collaborator Author

ll-nick commented Dec 9, 2024

Note that to test these changes, I'd have to merge multiple test PRs with the right timing. I don't think a change this simple is worth that effort so I'd just merge this without testing.

Copy link
Member

@orzechow orzechow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
As long as this is our only writing workflow the group key should be fine.

@ll-nick ll-nick merged commit e62afbc into main Dec 9, 2024
1 check passed
@ll-nick ll-nick deleted the prevent_concurrent_workflow_runs branch December 9, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prevent concurrent execution of version bump GitHub workflow
2 participants