Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve docker images (versioning, cleanup) #64

Merged
merged 4 commits into from
Oct 30, 2024
Merged

Conversation

orzechow
Copy link
Member

@orzechow orzechow commented Oct 29, 2024

Some cleanup and preps for

Based on pacman demo branch, because it also affects the demo docker image

@orzechow orzechow changed the base branch from main to pacman-demo October 29, 2024 15:08
@orzechow orzechow removed the request for review from ChristophBurger89 October 29, 2024 15:11
@orzechow
Copy link
Member Author

@ll-nick Could you have a brief look? 🙃

@ll-nick
Copy link
Collaborator

ll-nick commented Oct 30, 2024

Yup, that looks good to me :)

We'll have adjust #61 to copy the tests in the unit test stage (should we use this solution) but I'm guessing that you'll make some adjustments to that one anyway, so feel free to merge.

@orzechow
Copy link
Member Author

We'll have adjust #61 to copy the tests in the unit test stage (should we use this solution) but I'm guessing that you'll make some adjustments to that one anyway, so feel free to merge.

Good point, I added it here, see 68c648d

Btw. with an upcoming dockerfile version, we can shrink that copy command to a single line (and layer):
COPY --parents CMakeLists.txt cmake include test /tmp/arbitration_graphs/
See https://docs.docker.com/reference/dockerfile/#copy---parents

@orzechow orzechow merged commit 233d800 into pacman-demo Oct 30, 2024
@orzechow orzechow deleted the improve_docker branch October 30, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants