Improve citation section of Readme #81
Conversation
orzechow
force-pushed
the
improve_citation_section
branch
from
7bc58b5 to
b0346c4
Compare
README.md
Outdated
|
|
||
| _Piotr F. Orzechowski, “Verhaltensentscheidung für automatisierte Fahrzeuge mittels Arbitrationsgraphen,” phd, Karlsruher Institut für Technologie (KIT), 2023. doi: [10.5445/IR/1000160638](https://doi.org/10.5445/IR/1000160638)._ | ||
|
|
||
| {% raw %} |
There was a problem hiding this comment.
Just like in #83, these don't look great on the GitHub rendered page.
|
I just wanted to view these changes on locally built pages but I get the following error when starting the container. Any idea if that has something to do with this PR? Last week, this still worked. |
|
Just for the record (we solved this via chat): Simply |
There was a problem hiding this comment.
Thanks for this one! Generally I think this is a very nice change and is a nice improvement of the citation section.
I removed the {% raw %} just like in #83. However, the collapsible section does not render properly in Jekyll (see screenshot below). I hope that's not related to any local issues of my Jekyll setup. It does look great in the markdown render.
I added some suggestions regarding horizontal dividers but that's just an idea.
|
|
||
|
|
||
| <details> | ||
| <summary>Earlier publications</summary> |
There was a problem hiding this comment.
The entire section does not render properly for me via Jekyll. Looks fine on the pure markdown rendering and generally I think it's a good idea to use spoilers here.
| <details> | ||
| <summary>Earlier publications</summary> | ||
|
|
||
| A safety concept that extends Arbitration Graphs with behavior verification and fallback layers in the context of automated driving has been proposed by Piotr Spieker (née Orzechowski) in his PhD thesis. |
There was a problem hiding this comment.
I'd add horizontal dividers between the publications to distinguish more easily which part belongs where. See also the analogous suggestions below.
| A safety concept that extends Arbitration Graphs with behavior verification and fallback layers in the context of automated driving has been proposed by Piotr Spieker (née Orzechowski) in his PhD thesis. | |
| --- | |
| A safety concept that extends Arbitration Graphs with behavior verification and fallback layers in the context of automated driving has been proposed by Piotr Spieker (née Orzechowski) in his PhD thesis. |
| ``` | ||
| {% endraw %} | ||
|
|
||
| Arbitration Graphs replaced state machines in the context of automated driving at the Institute of Measurement and Control Systems (MRT) of the Karlsruhe Institute of Technology (KIT): |
There was a problem hiding this comment.
| Arbitration Graphs replaced state machines in the context of automated driving at the Institute of Measurement and Control Systems (MRT) of the Karlsruhe Institute of Technology (KIT): | |
| --- | |
| Arbitration Graphs replaced state machines in the context of automated driving at the Institute of Measurement and Control Systems (MRT) of the Karlsruhe Institute of Technology (KIT): |
|
|
||
| The foundations for Arbitration Graphs have been proposed in the context of robot soccer: |
There was a problem hiding this comment.
| The foundations for Arbitration Graphs have been proposed in the context of robot soccer: | |
| --- | |
| The foundations for Arbitration Graphs have been proposed in the context of robot soccer: |
|
Let me try again tomorrow. I think I did but let me test it in a clean state to make sure the fault is not in my local setup. |
|
Just for reference:
This did not actually work. I had to |
|
Ok, I cleaned the Gemfile one more time and started the local Jekyll setup, now it rendered fine. Therefore I take back my complaints and will approve this PR :) |
|
Follow-up PR: #86 |
This collapses all but one citation for better appearance.
It also adds my thesis to the citations.