Bugfix: avoid a segfault in the property editor due to invalid array …

…access (difficult to reproduce).
KLayout · Aug 7, 2024 · d31c9db · d31c9db
1 parent 4631a80
commit d31c9db
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/src/layui/layui/layPropertiesDialog.cc b/src/layui/layui/layPropertiesDialog.cc
@@ -379,7 +379,7 @@ PropertiesDialog::update_controls ()
 
   mp_ui->apply_to_all_cbx->setChecked (m_object_indexes.size () > 1);
 
-  if (m_index < 0) {
+  if (m_index < 0 || m_index >= int (mp_properties_pages.size ())) {
 
     mp_stack->setCurrentWidget (mp_none);
 
@@ -552,6 +552,10 @@ PropertiesDialog::apply ()
 {
 BEGIN_PROTECTED
 
+  if (m_index < 0 || m_index >= int (mp_properties_pages.size ())) {
+    return;
+  }
+
   db::Transaction t (mp_manager, tl::to_string (QObject::tr ("Apply changes")), m_transaction_id);
 
   try {