Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added script to build/deploy in MSYS2/ucrt64 environments #1575

Merged
merged 4 commits into from
Dec 16, 2023

Conversation

wsteffe
Copy link
Contributor

@wsteffe wsteffe commented Dec 14, 2023

No description provided.

@wsteffe
Copy link
Contributor Author

wsteffe commented Dec 15, 2023

I am closing it because I want revert back last commit (added installer ...).
The installer is uploaded to the separate repo https://github.com/wsteffe/klayout_releases_ucrt64

@wsteffe wsteffe closed this Dec 15, 2023
This reverts commit d524bc1.

installer is uploaded on a separate repository
@wsteffe wsteffe reopened this Dec 15, 2023
@wsteffe
Copy link
Contributor Author

wsteffe commented Dec 15, 2023

I am reopening tje pull request after haveing reverted the last commit (it may not be cancelled).
Anyway installer file was never pushed because large files can't be pushed on a public fork.

@wsteffe
Copy link
Contributor Author

wsteffe commented Dec 15, 2023

Hi Matthias,
to build and deploy in ucrt64 you have to execute script/deploy-win-ucrt64.sh from the shell ucrt64 (not msys shell as written at https://www.klayout.de/build.html for deploy-win-mingw.sh).

Beside changing mingw_inst=/mingw64 to ucrt_inst=/ucrt64 and other similar changes I have also fixed a problem in finding Binary dependencies:

libs=$(objdump -p $new_libs | grep "DLL Name:" | sort -u | sed 's/.*DLL Name: *//')

gave an error: argument list too long for objdump and the set of copied dlls was not complete.

@klayoutmatthias klayoutmatthias merged commit 5396a38 into KLayout:master Dec 16, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants