Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a new environment variable "KLAYOUT_INPUT_HTTP_STREAM_PRIVA… #1762

Closed
wants to merge 1 commit into from

Conversation

Kazzz-S
Copy link
Contributor

@Kazzz-S Kazzz-S commented Jun 29, 2024

…TE_DATA_TIMEOUT" to control the timeout for XML document fetching

This is my idea to address the issue #1756.

…TE_DATA_TIMEOUT" to control the timeout for XML document fetching
@klayoutmatthias
Copy link
Collaborator

HI @Kazzz-S,

thanks for this PR.

It is fine with me to call the variable simply "KLAYOUT_HTTP_TIMEOUT". That is more generic and fits the purpose.

Matthias

@klayoutmatthias
Copy link
Collaborator

Hi @Kazzz-S,

I hope it's not a problem I created an alternative proposal here: #1764

Reason is that there is also the non-Qt, curl-based HTTP(S) implementation and I wanted both to behave the same. The curl version was not thrown an exception in case of timeouts, so I added this too. I also added a test and named the variable "KLAYOUT_HTTP_TIMEOUT".

Maybe you can take a look there.

Thanks,

Matthias

@Kazzz-S
Copy link
Contributor Author

Kazzz-S commented Jun 30, 2024

Hi @klayoutmatthias,

Thank you for taking care of the non-Qt case, too.
Of course, the new implementation is OK with me.

Regards,
Kazzz-S

@Kazzz-S
Copy link
Contributor Author

Kazzz-S commented Jun 30, 2024

Hi @klayoutmatthias,

I have tested #1764 on macOS, which works fine.

Thank you.
Kazzz-S

@Kazzz-S Kazzz-S closed this Jul 1, 2024
@Kazzz-S Kazzz-S deleted the issue-1756 branch July 1, 2024 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants