Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing issue #1793 (problem with default arguments in Python) #1795

Merged
merged 7 commits into from
Jul 27, 2024
Merged

Fixing issue #1793 (problem with default arguments in Python) #1795

merged 7 commits into from
Jul 27, 2024

Conversation

klayoutmatthias
Copy link
Collaborator

No description provided.

Matthias Koefferlein added 2 commits July 20, 2024 21:02
@klayoutmatthias klayoutmatthias linked an issue Jul 20, 2024 that may be closed by this pull request
inconsistent results in width_check when calling by keyword argument (python) #1793
Closed
tvt173
tvt173 approved these changes Jul 26, 2024
View reviewed changes
Copy link

@tvt173 tvt173 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix and additional tests! the changes look reasonable as far as i can tell. let me know if you'd like me to test anything on my end

@klayoutmatthias klayoutmatthias merged commit 113e47a into master Jul 27, 2024
24 checks passed
@klayoutmatthias klayoutmatthias deleted the bugfix/issue-1793 branch July 27, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tvt173 tvt173 tvt173 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

inconsistent results in width_check when calling by keyword argument (python)
2 participants
@klayoutmatthias @tvt173