Implemented solution for issue #1836 (Allow the usage of Cell.shapes(… #1849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…LayerInfo(...))) - For Cell#shapes, LayerInfo is an accepted argument now - If the layer does not exist, it is created (non-const version) or an error is raised (const version) - Cell#clear also accepts a LayerInfo object - Layout#clear and Layout#delete_layer also accept a LayerInfo parameter Rationale for supporting the clear and delete_layer methods: These cases do nothing if the layer does not exist, so there is a benefit of using them: it is not required to check first if the layer exists.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…LayerInfo(...)))
Rationale for supporting the clear and delete_layer methods: These cases do nothing if the layer does not exist, so there is a benefit of using them: it is not required to check first if the layer exists.