Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose dbRecursiveShapeIterator::next(RecursiveShapeReceiver*) #1868

Closed
wants to merge 1 commit into from

Conversation

rocallahan
Copy link
Contributor

This is extremely useful when you want the flexibility of pull-based iteration, but you also need notifications when entering and leaving cells.

This is extremely useful when you want the flexibility of pull-based
iteration, but you also need notifications when entering and
leaving cells.
@klayoutmatthias
Copy link
Collaborator

Could you explain the context? Are you working on a C++ extension? Is there a project link?

This is not exposing the function externally in a way. The patch makes sense if you have C++ code based on this class. But in general I discourage that. There is no warranty for the C++ API. It may change without notice.

Matthias

@rocallahan
Copy link
Contributor Author

Could you explain the context? Are you working on a C++ extension? Is there a project link?

We have some C++ code using KLayout as a library. That code is not open-source (and is only used internally).

This is not exposing the function externally in a way. The patch makes sense if you have C++ code based on this class. But in general I discourage that. There is no warranty for the C++ API. It may change without notice.

OK, that makes sense. Thanks for the warning. We'll deal with whatever changes you make.

I will assume you don't want this kind of change, then. We'll carry it locally. Thanks!!!

@rocallahan rocallahan closed this Oct 2, 2024
@rocallahan rocallahan deleted the iterator-next branch October 2, 2024 02:01
@klayoutmatthias
Copy link
Collaborator

Well, thanks for this clarification. I don't object to the change, but as there is no specific use within KLayout, I might as well refactor away this function or change its functionality. So accepting this PR would not mean anything, except a potentially short-living feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants