Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue #1925 (MAGIC import fails) #1927

Merged
merged 1 commit into from
Nov 28, 2024
Merged

Fixed issue #1925 (MAGIC import fails) #1927

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/plugins/streamers/magic/db_plugin/dbMAGReader.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -531,6 +531,9 @@ MAGReader::read_rlabel (tl::Extractor &ex, Layout &layout, cell_index_type cell_
std::string lname;
ex.read (lname);

// skip sticky flag (optional)
ex.test ("s");

double l, b, r, t;
ex.read (l);
ex.read (b);
Expand Down
5 changes: 5 additions & 0 deletions src/plugins/streamers/magic/unit_tests/dbMAGReader.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,3 +156,8 @@ TEST(3)
run_test (_this, tl::testdata (), "ringo/RINGO.mag", "ringo_au.cif.gz");
}

TEST(4)
{
run_test (_this, tl::testdata (), "issue_1925/redux.mag", "redux_au.cif.gz");
}

9 changes: 9 additions & 0 deletions testdata/magic/issue_1925/redux.mag
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
magic
tech sky130A
timestamp 1731684784
<< metal4 >>
rect 0 0 10000 100
<< labels >>
rlabel metal4 s 10500 -9100 10600 12800 6 vccd1
port 1 nsew power input
<< end >>
Binary file added testdata/magic/redux_au.cif.gz
View file
Open in desktop
Binary file not shown.
Loading