Issue/#41 #73
Merged
Issue/#41 #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwonssshyeon
force-pushed
the
issue/#41
branch
from
ed034db to
ffc5667
Compare
momnpa333
reviewed
Sep 4, 2024
Comment on lines
+60
to
+70
| assertThat(users.size()).isEqualTo(5); | ||
| assertThat(users.get(0).getNickname()).isEqualTo("user5"); | ||
| assertThat(users.get(1).getNickname()).isEqualTo("user4"); | ||
| assertThat(users.get(2).getNickname()).isEqualTo("user3"); | ||
| assertThat(users.get(3).getNickname()).isEqualTo("user2"); | ||
| assertThat(users.get(4).getNickname()).isEqualTo("user1"); | ||
|
|
||
| assertThat(users.get(0).getExp()).isGreaterThan(users.get(1).getExp()); | ||
| assertThat(users.get(1).getExp()).isGreaterThan(users.get(2).getExp()); | ||
| assertThat(users.get(2).getExp()).isGreaterThan(users.get(3).getExp()); | ||
| assertThat(users.get(3).getExp()).isGreaterThan(users.get(4).getExp()); |
There was a problem hiding this comment.
assertAll์ ์ฌ์ฉํ๋ฉด ์กฐ๊ธ ๋ ๊ฐ๋ ์ฑ ์๊ฒ ํ ์คํธ ํ์ธ์ด ๊ฐ๋ฅํด์!
There was a problem hiding this comment.
๋ต ๋ค์์ ์์ ํ ๋ ๋ฐ์ํด๋ณด๊ฒ ์ต๋๋ค !
|
์ด์ ์ผ approve๋ฅผ ๋๋ฆฌ๋ค์ฉ ๋ค์๋ถํฐ๋ ๋ฐ๋ก๋ฐ๋ก ๋ฆฌ๋ทฐํด๋๋ฆด๊ฒ์ฉ ๊ณ ์ํ์ จ์ต๋๋ค! |
momnpa333
approved these changes
Sep 4, 2024
bayy1216
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
๐ ์์ ๋ด์ฉ
To Reviewers ๐ข
์ฒดํฌ ๋ฆฌ์คํธ
โ ๊ด๋ จ ์ด์