Fix GUI sort by size #2311
Closed
Fix GUI sort by size #2311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HebaruSan
added
GUI
|
I saw that comment and thought this would be the way to do it, but I had not a clue how to start. |
politas
added a commit
to politas/CKAN
that referenced
this pull request
Feb 24, 2018
HebaruSan
force-pushed
the
fix/sort-by-size
branch
from
71ad317
to
88ee738
Compare
|
@politas , I think you merged this into your own fork rather than KSP-CKAN's. Was that intentional? |
|
Ah, must have missed the push to the main fork. I'll fix it when I get home. |
|
Ok, some definite weirdness happened. This has now been merged, though I broke the GitHub PR connection in the process. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
#2277 updated the Download column in GUI to use "B", "KB", "MB", and "GB" units depending on the magnitude of the size. Previously this column was always in KB.
Problem
This broke the sorting of this column. There doesn't seem to be a pattern to it anymore.
Cause
The size sort code depended on parsing the text of the cells, which is no longer useful when the units aren't the same or when the strings contain more than just numeric digits.
Changes
Now the Download column sorts directly by the raw size data. The largest mods are:
Fixes https://forum.kerbalspaceprogram.com/index.php?/topic/154922-ckan-the-comprehensive-kerbal-archive-network-v1240-bruce/&do=findComment&comment=3303380 .