affine transform util: add interoperability with AffineMaps #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorendumoulin
changed the title
jorendumoulin
force-pushed
the
joren/affine-util-from-map
branch
from
c88d37a to
c033f38
Compare
JosseVanDelm
requested changes
Jan 3, 2025
There was a problem hiding this comment.
Tests are looking great, but could you add a bit more descriptive comments?
E.g. right now it is quite difficult to read what is going on.
For example, what does generate_one_list do?
Something like:
construct a matrix representation of the affine expression by evaluating the dimensions one by one...
Also, can you add a check such that the input affine expr does not contain any of the invariants (floordiv/ceildiv)?
JosseVanDelm
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to keep interoperability with xdsl afinemaps, and to enable a more gradual migration to affinetransforms, include the constructors
from_affine_mapandto_affine_map