template matching: only look at the inner dims of the schedule #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JosseVanDelm
approved these changes
Jan 28, 2025
tests/ir/dart/test_access_pattern.py
Outdated
| sp_non_matching_pattern = SchedulePattern( | ||
| bounds, | ||
| AffineMap( | ||
| num_dims=2, num_symbols=0, results=(AffineDimExpr(1), AffineDimExpr(0)) | ||
| ), | ||
| ) | ||
| assert tp.matches(sp_non_matching_pattern) is False | ||
|
|
||
| # check pattern with wrong bounds (should be irellevant for template check) |
There was a problem hiding this comment.
Suggested change
| # check pattern with wrong bounds (should be irellevant for template check) | |
| # check pattern with wrong bounds (should be irrelevant for template check) |
compiler/ir/dart/access_pattern.py
Outdated
| @@ -196,6 +196,8 @@ def matches(self, sp: SchedulePattern): | |||
| Check if a given schedule pattern matches this | |||
| template pattern. | |||
| """ | |||
| if sp.num_dims > self.num_dims: | |||
| sp = sp.inner_dims(self.num_dims) | |||
| if sp.num_dims != self.num_dims: | |||
There was a problem hiding this comment.
maybe make this more explicit?
Suggested change
| if sp.num_dims != self.num_dims: | |
| elif sp.num_dims < self.num_dims: |
jorendumoulin
force-pushed
the
joren/template-match-inner
branch
from
a04dc2b to
d08edb2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stacked on #349
with this PR, when doing a template check with a template and a schedule, previously they are forced to the same number of dims. This PR checks if the schedule has larger dimensionality than the template, and reduces it to the number of dims of the template in this case.