add optional output stationary check #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JosseVanDelm
approved these changes
Jan 28, 2025
compiler/ir/dart/scheduler.py
Outdated
| """ | ||
| Checks whether a schedule, outside of the template, is fully output | ||
| stationary. This is determined by making sure all parallel dimensions | ||
| preced the reduction dimensions in the output operand (last operand). |
There was a problem hiding this comment.
Suggested change
| preced the reduction dimensions in the output operand (last operand). | |
| precede the reduction dimensions in the output operand (last operand). |
| @@ -7,6 +9,7 @@ def scheduler_backtrack( | |||
| template: Template, | |||
| schedule: Schedule, | |||
| inner_dims: int = 1, | |||
| extra_checks: Sequence[Callable[[Template, Schedule], bool]] = [], | |||
jorendumoulin
force-pushed
the
joren/backtracking-scheduler
branch
from
e5362ce to
8eb7eab
Compare
jorendumoulin
force-pushed
the
joren/os-check
branch
from
570f122 to
7f17cc1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stacked on #350
This one adds the capability to the scheduler to add extra checks/ constraints to filter out unwanted schedules, and adds a check to only accept pure output stationary (= never send partial results back to memory) schedules.
This is a useful check for for example accelerators which do not have the capability to preload partial results. In our case the codegen further down the pipeline is not yet capable of non-output stationary schedules.
Currently, this constraint is embedded in accelerator templates in a hacky way. This way of handling things makes it more explicit and controllable.