Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add simplify method to tiled strided layouts #360

Merged
merged 2 commits into from
Feb 5, 2025
Merged

Conversation

jorendumoulin
Copy link
Contributor

No description provided.

Copy link
Contributor

@JosseVanDelm JosseVanDelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe call it canonicalize?

@@ -73,6 +74,33 @@ def __iter__(self) -> Iterator[tuple[int, Stride]]:
"""
return enumerate(self.strides)

def simplify(self) -> Self:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this not a canonicalize-ation?

@jorendumoulin jorendumoulin merged commit f5ea243 into main Feb 5, 2025
14 checks passed
@jorendumoulin jorendumoulin deleted the joren/simplify-tsl branch February 5, 2025 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants