Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add numpy dependency explicitly #363

Merged
merged 3 commits into from
Feb 5, 2025
Merged

add numpy dependency explicitly #363

merged 3 commits into from
Feb 5, 2025

Conversation

jorendumoulin
Copy link
Contributor

We use it for quite some things now

JosseVanDelm
JosseVanDelm approved these changes Feb 5, 2025
View reviewed changes
Copy link
Contributor

@JosseVanDelm JosseVanDelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like a good idea! Can you fix the lock-file ?

@jorendumoulin jorendumoulin merged commit 4a6ccfd into main Feb 5, 2025
14 checks passed
@jorendumoulin jorendumoulin deleted the joren/numpy-dep branch February 5, 2025 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JosseVanDelm JosseVanDelm JosseVanDelm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jorendumoulin @JosseVanDelm