-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve stenosis #33
Improve stenosis #33
Conversation
Looks good. Can you show me the command you use to generate the mesh? |
HI @johannesring The command I used is given here :) |
Thanks, I missed that. |
@dbruneau-mie Could you please review this change? Here is also an animation of the flow field. |
Hi @dbruneau-mie |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, but it would be nice to have a link or some guide on how to access the mesh/surfaces.
@dbruneau-mie I'll add the instructions about the mesh! And yes viscosity is lowered to generate turbulence. |
Codecov Report
@@ Coverage Diff @@
## master #33 +/- ##
=========================================
Coverage ? 71.72%
=========================================
Files ? 10
Lines ? 1192
Branches ? 0
=========================================
Hits ? 855
Misses ? 337
Partials ? 0 |
@dbruneau-mie @johannesring @jorgensd @KristianValen-Sendstad As discussed in the previous meeting, we will move surface and mesh data to |
This PR adds
offset_stenosis.py
. We use x-coordinate to determine the FSI region instead of sphere.data/models
and a stl file for the offset stenosis problem. The reason for creating a folderdata
as a parent folder ofmodels
is that we might want to create other folder for storing data necessary to run simulations (right now we have data for boundary conditions insrc/fsipy/simulations
but should be moved later?)Please let me know if you have suggestions! For now, the boundary ID in the mesh and ID in
.json
file do not always match, so the boundary IDs are hard-coded. It would be nice to improve this so that it is automated to create boundary conditions.