Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve stenosis #33

Merged
merged 8 commits into from
Sep 19, 2023
Merged

Improve stenosis #33

merged 8 commits into from
Sep 19, 2023

Conversation

keiyamamo
Copy link
Collaborator

This PR adds

  1. Improvement of offset_stenosis.py. We use x-coordinate to determine the FSI region instead of sphere.
  2. a folder data/models and a stl file for the offset stenosis problem. The reason for creating a folder data as a parent folder of models is that we might want to create other folder for storing data necessary to run simulations (right now we have data for boundary conditions in src/fsipy/simulations but should be moved later?)

Please let me know if you have suggestions! For now, the boundary ID in the mesh and ID in .json file do not always match, so the boundary IDs are hard-coded. It would be nice to improve this so that it is automated to create boundary conditions.

@johannesring
Copy link
Collaborator

Looks good. Can you show me the command you use to generate the mesh?

@keiyamamo
Copy link
Collaborator Author

Looks good. Can you show me the command you use to generate the mesh?

HI @johannesring The command I used is given here :)

@johannesring
Copy link
Collaborator

HI @johannesring The command I used is given here :)

Thanks, I missed that.

@keiyamamo
Copy link
Collaborator Author

stenosis

@dbruneau-mie Could you please review this change? Here is also an animation of the flow field.

@keiyamamo
Copy link
Collaborator Author

Hi @dbruneau-mie
It would be nice if you could have a look on this.
Best,
Kei

Copy link
Collaborator

@dbruneau-mie dbruneau-mie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, but it would be nice to have a link or some guide on how to access the mesh/surfaces.

src/fsipy/simulations/offset_stenosis.py Show resolved Hide resolved
@keiyamamo
Copy link
Collaborator Author

@dbruneau-mie I'll add the instructions about the mesh! And yes viscosity is lowered to generate turbulence.

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@e96d1a0). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #33   +/-   ##
=========================================
  Coverage          ?   71.72%           
=========================================
  Files             ?       10           
  Lines             ?     1192           
  Branches          ?        0           
=========================================
  Hits              ?      855           
  Misses            ?      337           
  Partials          ?        0           

@keiyamamo
Copy link
Collaborator Author

@dbruneau-mie @johannesring @jorgensd @KristianValen-Sendstad

As discussed in the previous meeting, we will move surface and mesh data to Zenodo.
At the same time, I added a README file inside simulations folder which will explains where to get the surface data and how to reproduce the mesh. Zenodo requires project name, so I will wait until we land on the name of the repository but will add necessary data as soon as we decide the name.

@keiyamamo keiyamamo merged commit f43e1a3 into KVSlab:master Sep 19, 2023
5 checks passed
@keiyamamo keiyamamo deleted the improve_stenosis branch December 4, 2023 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants