chore: upgraded ibc

[troykessler]

Summary by CodeRabbit

• Chores

  • Integrated an updated version of the IBC Go library, which may enhance performance and stability.

• Bug Fixes

  • Removed verification and output logic for the "kaon" network, streamlining the verification process to focus solely on the "mainnet" network.

• Tests

  • Added a new test case to verify the behavior when claiming pending rewards multiple times, ensuring consistency in balances and rewards after toggling the MultiCoin rewards feature.

[coderabbitai]

Walkthrough

The pull request includes an update to the go.mod file, changing the version of the github.com/cosmos/ibc-go/v8 dependency from v8.5.2 to v8.6.1. Additionally, the verify.py file has undergone modifications where the verification logic for the "kaon" network has been removed, including the associated variable and print statements. The remaining code continues to handle the "mainnet" network. Furthermore, changes in msg_server_toggle.go enhance the processing of pending rewards, while a new test case in msg_server_toggle_test.go validates the functionality of claiming rewards multiple times.

Changes

File	Change Summary
go.mod	Updated dependency: github.com/cosmos/ibc-go/v8 version changed from v8.5.2 to v8.6.1.
app/upgrades/v2_0/validator-proofs/verify.py	Removed verification logic and output for the "kaon" network, including variable status_kaon.
x/multi_coin_rewards/keeper/msg_server_toggle.go	Modified context handling and added reward removal logic in ToggleMultiCoinRewards function.
x/multi_coin_rewards/keeper/msg_server_toggle_test.go	Added new test case for claiming pending rewards twice.

Possibly related PRs

• chore: bump CosmosSDK to v0.50.11 and cleanup deps #213: The changes in the main PR, which involve updating the version of the github.com/cosmos/ibc-go/v8 dependency, are related to the retrieved PR that also updates the same dependency in its go.mod file, indicating a direct connection at the code level.

Suggested reviewers

• christopherbrumm

Poem

I'm a rabbit, light on my paws,
Hopping through code with a cheerful pause.
Found a change in the go.mod field so neat,
Upgraded dependencies make my day complete.
With twitching nose and joyful glee,
I celebrate this update like a bouncy spree!

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between de3d555 and de0315c.

📒 Files selected for processing (2)

• x/multi_coin_rewards/keeper/msg_server_toggle.go (1 hunks)
• x/multi_coin_rewards/keeper/msg_server_toggle_test.go (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: Summary

🔇 Additional comments (2)

x/multi_coin_rewards/keeper/msg_server_toggle.go (1)

30-35:

✅ Verification successful

Improved reward processing with proper cleanup

The changes properly handle the context conversion and introduce an important cleanup step by removing each pending rewards entry after processing. This prevents potential double-claiming of rewards when toggling the feature off and on again.

---

🏁 Script executed:

#!/bin/bash
# Description: Look for other instances where pending rewards might be processed but not removed

# First, let's find all files that might be handling pending rewards
rg -A 2 "GetMultiCoinPendingRewards" --type go

Length of output: 2531

---

Reward cleanup in toggle has been correctly implemented

The revised code in x/multi_coin_rewards/keeper/msg_server_toggle.go now properly unwraps the SDK context, aggregates the pending rewards, and removes each processed reward entry. This cleanup step effectively prevents double-claiming when toggling the feature off and on again. Our review of other parts of the code (like in logic_distribution.go and the gRPC query handlers) shows that they handle pending rewards as read-only or in a context-specific manner, so the explicit removal in the toggle handler is appropriate for its intended purpose.

x/multi_coin_rewards/keeper/msg_server_toggle_test.go (1)

242-280: Good test coverage for the double-claiming prevention

This test case properly validates that the newly implemented rewards cleanup is working correctly by verifying that toggling MultiCoin rewards off and back on doesn't result in claiming the same rewards twice. The test demonstrates the exact scenario the code change is meant to address.

✨ Finishing Touches

• 📝 Generate Docstrings

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

go.mod (1)

27-27: Upgrade IBC Dependency Version

The version of github.com/cosmos/ibc-go/v8 has been updated to v8.6.1. Please verify that this upgrade does not introduce any compatibility issues or require any changes in your codebase. Checking the release notes or migration guide for IBC Go can help ensure smooth integration.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8fcdc76 and 0e28103.

⛔ Files ignored due to path filters (2)

• go.sum is excluded by !**/*.sum
• go.work.sum is excluded by !**/*.sum

📒 Files selected for processing (1)

• go.mod (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: Summary