Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update: validate & build workflows. #8

Merged
merged 1 commit into from
Nov 28, 2023
Merged

update: validate & build workflows. #8

merged 1 commit into from
Nov 28, 2023

Conversation

christopherbrumm
Copy link
Member

This PR updates the GitHub workflows. Instead of generating a release containing the registry.yml as release asset, the GitHub workflow writes the built Source-Registry into .github/registry.yml after validating the <source>/config.yml schemas.

fabianriewe
fabianriewe approved these changes Nov 28, 2023
View reviewed changes
Copy link
Member

@fabianriewe fabianriewe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, we need to update the python scripts in another PR

@fabianriewe fabianriewe merged commit be6ce42 into main Nov 28, 2023
1 check passed
@christopherbrumm christopherbrumm deleted the update/workflow branch November 30, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabianriewe fabianriewe fabianriewe approved these changes

@mbreithecker mbreithecker Awaiting requested review from mbreithecker mbreithecker is a code owner

@troykessler troykessler Awaiting requested review from troykessler troykessler is a code owner

@shifty11 shifty11 Awaiting requested review from shifty11

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@christopherbrumm @fabianriewe