Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename react package to core-react #127

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ju-Skinner
Copy link
Collaborator

@ju-Skinner ju-Skinner commented Dec 15, 2023

Description

In the sake that there may be confusion, I elected to rename the pine-ds/react package to pine-ds/core-react. The name will then imply that this is the core React design system components.

Ticket: https://kajabi.atlassian.net/browse/DSS-497

Copy link

netlify bot commented Dec 15, 2023

Deploy Preview for pine-design-system ready!

Name Link
🔨 Latest commit ebeb5e7
🔍 Latest deploy log https://app.netlify.com/sites/pine-design-system/deploys/659f16573073d7000970c815
😎 Deploy Preview https://deploy-preview-127--pine-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ju-Skinner ju-Skinner requested a review from a team December 15, 2023 20:44
Copy link
Contributor

github-actions bot commented Dec 15, 2023

Dependency Review

The following issues were found:
  • ✅ 0 vulnerable package(s)
  • ✅ 0 package(s) with incompatible licenses
  • ✅ 0 package(s) with invalid SPDX license definitions
  • ⚠️ 3 package(s) with unknown licenses.
See the Details below.

License Issues

libs/core-react/package.json

PackageVersionLicenseIssue Type
@pine-ds/icons3.4.0NullUnknown License
@pine-ds/core^0.0.2-rc.0NullUnknown License

package-lock.json

PackageVersionLicenseIssue Type
libs/core-react0.0.2-rc.0NullUnknown License
Denied Licenses: LGPL-2.0, AAL, Adobe-2006, Afmparse, Artistic-1.0, Artistic-1.0-cl8, Artistic-1.0-Perl, Beerware, blessing, Borceux, CECILL-B, ClArtistic, Condor-1.1, Crossword, CrystalStacker, diffmark, DOC, EFL-1.0, EFL-2.0, Fair, FSFUL, FSFULLR, Giftware, HPND, IJG, Leptonica, LPL-1.0, LPL-1.02, MirOS, mpich2, NASA-1.3, NBPL-1.0, Newsletr, NLPL, NRL, OGTSL, OLDAP-1.1, OLDAP-1.2, OLDAP-1.3, OLDAP-1.4, psutils, Qhull, Rdisc, RSA-MD, Spencer-86, Spencer-94, TU-Berlin-1.0, TU-Berlin-2.0, Vim, W3C-19980720, W3C-20150513, Wsuipa, WTFPL, xinetd, Zed, Zend-2.0, ZPL-1.1, AGPL-1.0-only, AGPL-1.0-or-later, AGPL-3.0-only, AGPL-3.0-or-later, APSL-1.0, APSL-1.1, APSL-1.2, APSL-2.0, CPAL-1.0, EUPL-1.0, EUPL-1.1, EUPL-1.2, NPOSL-3.0, OSL-1.0, OSL-1.1, OSL-2.0, OSL-2.1, OSL-3.0, RPSL-1.0, SSPL-1.0, CAL-1.0, CAL-1.0-Combined-Work-Exception, Parity-6.0.0, Parity-7.0.0, RPL-1.1, RPL-1.5, EPL-1.0, EPL-2.0, ErlPL-1.1, IPL-1.0, LGPL-2.0-only, LGPL-2.0-or-later, LGPL-2.1-only, LGPL-2.1-or-later, LGPL-2.1, LGPL-3.0-only, LGPL-3.0-or-later, LGPL-3.0, MPL-1.0, MPL-1.1, MPL-2.0, MPL-2.0-no-copyleft-exception, MS-RL, SPL-1.0, BSD-Protection, copyleft-next-0.3.0, copyleft-next-0.3.1, GPL-1.0-only, GPL-1.0-or-later, GPL-1.0, GPL-2.0-only, GPL-2.0-or-later, GPL-2.0, GPL-3.0-only, GPL-3.0-or-later, GPL-3.0, QPL-1.0, Sleepycat

Scanned Manifest Files

libs/core-react/package.json
  • @pine-ds/core@^0.0.2-rc.0
  • @pine-ds/[email protected]
  • @rollup/plugin-typescript@^11.1.5
  • @testing-library/jest-dom@^6.1.3
  • @types/jest@^29.1.2
  • @types/node@^18.8.4
  • @types/react@^18.0.21
  • @types/react-dom@^18.0.6
  • jest@^29.1.2
  • np@^3.1.0
  • react@^17.0.2
  • react-dom@^17.0.2
  • ts-jest@^29.0.3
  • typescript@^4.8.4
package-lock.json
libs/react/package.json
  • @pine-ds/core@^0.0.2-rc.0
  • @pine-ds/[email protected]
  • @rollup/plugin-typescript@^11.1.5
  • @testing-library/jest-dom@^6.1.3
  • @types/jest@^29.1.2
  • @types/node@^18.8.4
  • @types/react@^18.0.21
  • @types/react-dom@^18.0.6
  • jest@^29.1.2
  • np@^3.1.0
  • react@^17.0.2
  • react-dom@^17.0.2
  • ts-jest@^29.0.3
  • typescript@^4.8.4

@github-actions github-actions bot added the package: core Changes have been made to the Core package label Dec 15, 2023
@pixelflips pixelflips requested a review from a team December 15, 2023 20:45
@ju-Skinner ju-Skinner self-assigned this Dec 15, 2023
Copy link
Contributor

@anechol anechol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me

@ju-Skinner ju-Skinner force-pushed the next branch 3 times, most recently from 5f89487 to 46929a2 Compare January 10, 2024 15:42
@ju-Skinner ju-Skinner force-pushed the chore/rename-react-package-to-core-react branch from 306cd26 to ebeb5e7 Compare January 10, 2024 22:12
@ju-Skinner ju-Skinner changed the base branch from next to main January 11, 2024 16:13
@ju-Skinner ju-Skinner force-pushed the main branch 8 times, most recently from 7ed4abf to b454f1e Compare May 16, 2024 19:10
@ju-Skinner ju-Skinner force-pushed the main branch 5 times, most recently from 30dded3 to b6dea18 Compare September 9, 2024 18:37
@ju-Skinner ju-Skinner force-pushed the main branch 9 times, most recently from 325ab65 to c0401f4 Compare September 9, 2024 21:52
@ju-Skinner ju-Skinner force-pushed the main branch 4 times, most recently from bab7cd1 to 05e3572 Compare February 3, 2025 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core Changes have been made to the Core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants