Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OS-249] Add new pi3 revision code #295

Merged
merged 1 commit into from
Aug 23, 2018
Merged

[OS-249] Add new pi3 revision code #295

merged 1 commit into from
Aug 23, 2018

Conversation

Ealdwulf
Copy link
Contributor

This PR adds the new pi3 resvision code reported in #294
We also need to add the 3B+, but lets do that once we know everything that needs doing for that.
OS-249

See https://www.raspberrypi.org/documentation/hardware/raspberrypi/revision-codes/README.md

Copy link
Member

@tombettany tombettany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you create a JIRA ticket to link with this so we have a record of whether it has been QA'd. Also, can you create another ticket to revisit how we do this detection because this highlights how fragile this whole mechanism is.

Copy link
Contributor

@radujipa radujipa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked on the official RPi docs, looks good :shipit:

Also, I started the 3B+ branch here a while back 5423ca1

@tombettany tombettany changed the title Add new pi3 revision code [OS-249] Add new pi3 revision code Aug 21, 2018
@tombettany tombettany merged commit bd68f65 into master Aug 23, 2018
@tombettany tombettany deleted the new_revision_code branch August 23, 2018 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants