Fix Docker build IV

[andy5995]

(Fixes #7)

[andy5995]

This worked on my fork https://github.com/andy5995/vs-fltk/pkgs/container/vs-fltk

[andy5995]

I do vaguely recalling getting a PAT to use ghcr from the command line.

These instructions seem to confusingly indicate that a PAT isn't needed to push from a workflow though.

https://docs.github.com/en/packages/working-with-a-github-packages-registry/working-with-the-container-registry#authenticating-to-the-container-registry

[andy5995]

@KaruroChori could you please check the repo settings mentioned here? docker/build-push-action#687 (comment)

[KaruroChori]

Thank you for you help!
I just tested the workflow in master after changing the permissions for the GITHUB_TOKEN as suggested and it works 🥳 .
I am not too happy with the amount of freedom I am giving to workflows to achieve that, so I might decide to set up an external more restricted token and use that for this specific workflow.
The important part is that there is now a functioning baseline and the image is properly generated.

[andy5995]

I figured we want the docker tests to run if any file except for the README is changed, because the tests works in conjunction with the scripts and docker-compose.yml... Hmmm... but maybe different filters are needed for docker.yml.

[andy5995]

but maybe different filters are needed for docker.yml.

I reverted the change below in docker.yml. In theory, if it passes this test, there's no reason to trigger it for the other one. The build should have already been triggered by any changes here.. or not...

I dunno. Let me know what you think. Or we could avoid some thought and adjust later as needed.

[KaruroChori]

I opened an issue so that I don't forget about this and we can delay the decision as right now I don't have strong feelings about one or the other option :D.

[andy5995]

I'm glad you got it working. It looks like only the buildcache was pushed though. That's because I forgot the 'tags' key (which is included in this PR).

[andy5995]

Rebased. Up to date with master @ 330bf4e

[KaruroChori]

@andy5995 I left some notes in the review, I will have to address those before merging it.